Repository navigation
fix(vdev): replace script wrapper macro with shared argument utility - #26469
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 of 2 tasks
pront
added
the
no-changelog
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 870ae697c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![datadoghq-integration[bot]](https://avatars.githubusercontent.com/u/16866914?s=60&v=4){kind=small}
pront
force-pushed
the
pront-vdev-script-args
branch
from
October 5, 2026 14:14
441117a to
865a001
Compare
1 of 2 tasks
pront
force-pushed
the
pront-vdev-script-args
branch
from
October 6, 2026 19:10
865a001 to
7f14b14
Compare
pront
force-pushed
the
pront-vdev-script-args
branch
from
October 6, 2026 19:12
7f14b14 to
8a85b6f
Compare
thomasqueirozb
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Script-backed vdev commands reject flags such as
vdev build manifests --chart-version ...before the underlying script runs.Changes
Replace
script_wrapper!with a sharedScriptArgsutility and explicit command-to-script mappings. All eight commands accept trailing hyphenated arguments, while preserving vdev help and explicit--forwarding.How did you test this PR?
make check-clippypassed across the workspace.make test, scoped to vdev by excluding the other workspace packages: 207 tests passed.Does this PR include user facing changes?